Render titles with source links for TIMDEX records #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18685707699Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
JPrevost
reviewed
Oct 21, 2025
JPrevost
approved these changes
Oct 21, 2025
Why these changes are being introduced: In TIMDEX UI, titles linked to full record views. That feature is not currently implemented in USE UI. Relevant ticket(s): * [USE-99](https://mitlibraries.atlassian.net/browse/USE-99) How this addresses that need: This updates TIMDEX title links to use the `source_link` field. Side effects of this change: When developing TIMDEX UI, we decided not to test any view logic. I've moved the logic in this change to the Search Helper in order to test it, but we may want to discuss whether to revisit integration testing in USE UI.
jazairi
force-pushed
the
use-99-title-links
branch
from
06704be to
f85e33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
In TIMDEX UI, titles linked to full record views. That feature is not currently implemented in USE UI.
Relevant ticket(s):
How this addresses that need:
This updates TIMDEX title links to use the
source_linkfield.Side effects of this change:
When developing TIMDEX UI, we decided not to test any view logic. I've continued that practice here, with some apprehension. (We've already missed a bug in the view while developing USE, which might have been avoided with more robust integration testing.) Not exactly a side effect, but perhaps a topic for future discussion.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
N/A
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing